Skip to content

fix: make Windows unit tests pass#244

Open
Eishaan-Khatri wants to merge 1 commit intohuggingface:mainfrom
Eishaan-Khatri:fix-windows-unit-suite
Open

fix: make Windows unit tests pass#244
Eishaan-Khatri wants to merge 1 commit intohuggingface:mainfrom
Eishaan-Khatri:fix-windows-unit-suite

Conversation

@Eishaan-Khatri
Copy link
Copy Markdown

fixed errors that occurred due to Windows-specific path and file-locking behavior:

  • Updated the backlog prioritization test so it checks path parts instead of assuming Unix-style / separators.
  • Replaced the POSIX-only fcntl session-file lock with a cross-platform lock helper that uses msvcrt on Windows and keeps fcntl on Unix.
  • Verified with uv run pytest tests/unit: 329 passed, 14 warnings

@Eishaan-Khatri Eishaan-Khatri force-pushed the fix-windows-unit-suite branch from 4e7a272 to 8d9e528 Compare May 7, 2026 15:01
@Eishaan-Khatri
Copy link
Copy Markdown
Author

The Windows unit suite passes locally with uv run pytest tests/unit (329 passed, 14 warnings). The failing Claude PR Review check appears to be a workflow permission issue on fork PRs rather than a code failure.

@Eishaan-Khatri Eishaan-Khatri force-pushed the fix-windows-unit-suite branch from 8d9e528 to 218f7ba Compare May 7, 2026 15:53
@Eishaan-Khatri
Copy link
Copy Markdown
Author

I have re-signed the latest commit, so the verified-signature requirement should now be resolved. The remaining failing check appears to be the Claude PR Review workflow permission issue for fork PRs.

I have used Codex for assistance in resolving the issue and creating pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant